Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Remove LazyString from 4.4, before adding back to the String component #34290

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 8, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

In #34190 I'm proposing to move LazyString to the Service contracts, but String might be a better fit actually. Let's remove the class from 4.4 where it's not really needed, and add it back on 5.0 in the String component.

@@ -1403,20 +1403,6 @@ public function testCacheDefaultRedisProvider()
$this->assertSame($redisUrl, $url);
}
public function testCacheDefaultRedisProviderWithEnvVar()

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Nov 8, 2019

Author Member

this test is just wrong :)

nicolas-grekas added a commit that referenced this pull request Nov 8, 2019
…he String component (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DI] Remove LazyString from 4.4, before adding back to the String component

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

In #34190 I'm proposing to move LazyString to the Service contracts, but String might be a better fit actually. Let's remove the class from 4.4 where it's not really needed, and add it back on 5.0 in the String component.

Commits
-------

b1a3ee7 [DI] Remove LazyString from 4.4, before adding back to the String component
@nicolas-grekas nicolas-grekas merged commit b1a3ee7 into symfony:4.4 Nov 8, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.