Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] [Workflow] Added a way to specify a message when blocking a transition + better default message in case it is not set #34573

Merged
merged 1 commit into from Nov 24, 2019

Conversation

@lyrixx
Copy link
Member

lyrixx commented Nov 24, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #34466
License MIT
Doc PR
@nicolas-grekas nicolas-grekas added this to the next milestone Nov 24, 2019
@lyrixx lyrixx force-pushed the lyrixx:workflow-set-blocked branch 2 times, most recently from cf237d9 to 2554de0 Nov 24, 2019
…n + better default message in case it is not set
@lyrixx lyrixx force-pushed the lyrixx:workflow-set-blocked branch from 2554de0 to 169bb2f Nov 24, 2019
@fabpot
fabpot approved these changes Nov 24, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Nov 24, 2019

Thank you @lyrixx.

fabpot added a commit that referenced this pull request Nov 24, 2019
…blocking a transition + better default message in case it is not set (lyrixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[DX] [Workflow] Added a way to specify a message when blocking a transition + better default message in case it is not set

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34466
| License       | MIT
| Doc PR        |

Commits
-------

169bb2f [Workflow] Added a way to specify a message when blocking a transition + better default message in case it is not set
@fabpot fabpot merged commit 169bb2f into symfony:master Nov 24, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@lyrixx lyrixx deleted the lyrixx:workflow-set-blocked branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.