Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier] added Sinch texter transport #34654

Open
wants to merge 3 commits into
base: master
from

Conversation

@imiroslavov
Copy link

imiroslavov commented Nov 27, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

This PR adds adapter for Sinch messaging gateway to the texter transport.

Example configuration:
sinch://SID:TOKEN@default?from=PHONE

@imiroslavov imiroslavov force-pushed the imiroslavov:feature/sinch-notifier branch 2 times, most recently from 70bdac8 to 1014673 Nov 27, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Nov 27, 2019
@fabpot fabpot added the Notifier label Feb 4, 2020
/**
* @author Iliya Miroslavov Iliev <i.miroslavov@gmail.com>
*
* @experimental in 5.0

This comment has been minimized.

Copy link
@OskarStark

OskarStark Feb 5, 2020

Contributor

5.1

This comment has been minimized.

Copy link
@imiroslavov

imiroslavov Feb 7, 2020

Author

Isn't this related to the notifier itself? It is experimental in 5.0 i'm not sure about how it would be in 5.1.

This comment has been minimized.

Copy link
@OskarStark

OskarStark Feb 7, 2020

Contributor

good question 🤔

friendly ping @nicolas-grekas

This comment has been minimized.

Copy link
@fabpot

fabpot Feb 15, 2020

Member

We are going to keep it experimental in 5.1.

CHANGELOG
=========

5.0.0

This comment has been minimized.

Copy link
@OskarStark

OskarStark Feb 5, 2020

Contributor

5.1

/**
* @author Iliya Miroslavov Iliev <i.miroslavov@gmail.com>
*
* @experimental in 5.0

This comment has been minimized.

Copy link
@OskarStark

OskarStark Feb 5, 2020

Contributor

5.1

@imiroslavov imiroslavov force-pushed the imiroslavov:feature/sinch-notifier branch from 8c5e760 to aea1ad3 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.