Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] never try loading failed classes twice with ClassExistenceResource #34762

Merged
merged 1 commit into from Dec 7, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 2, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #34658
License MIT
Doc PR -
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Dec 2, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:config-fix-exists-check branch from 05ce9a0 to df2bd83 Dec 2, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:config-fix-exists-check branch from df2bd83 to c20d7e2 Dec 3, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:config-fix-exists-check branch from c20d7e2 to 90c9a80 Dec 3, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 7, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Dec 7, 2019
…ExistenceResource (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Config] never try loading failed classes twice with ClassExistenceResource

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34658
| License       | MIT
| Doc PR        | -

Commits
-------

90c9a80 [Config] never try loading failed classes twice with ClassExistenceResource
@fabpot fabpot merged commit 90c9a80 into symfony:3.4 Dec 7, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.