Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge] Removed QueryBuilder type hint in getLoader() #34765

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@HeahDude
Copy link
Member

HeahDude commented Dec 2, 2019

Q A
Branch? 5.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR ~

Follows #34600.

@xabbuh
xabbuh approved these changes Dec 2, 2019
@chalasr
chalasr approved these changes Dec 2, 2019
@chalasr chalasr added this to the 5.0 milestone Dec 2, 2019
@HeahDude HeahDude force-pushed the HeahDude:fix-qb branch from 8eef8c8 to 8621852 Dec 4, 2019
@fabpot
fabpot approved these changes Dec 5, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 5, 2019

Thank you @HeahDude.

fabpot added a commit that referenced this pull request Dec 5, 2019
…er() (HeahDude)

This PR was merged into the 5.0 branch.

Discussion
----------

[DoctrineBridge] Removed QueryBuilder type hint in getLoader()

| Q             | A
| ------------- | ---
| Branch?       | 5.0 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ~
| License       | MIT
| Doc PR        | ~
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->
Follows #34600.

Commits
-------

8621852 [DoctrineBridge] Removed QueryBuilder type hint in getLoader()
@fabpot fabpot merged commit 8621852 into symfony:5.0 Dec 5, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@HeahDude HeahDude deleted the HeahDude:fix-qb branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.