Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bad order of operations with null coalescing operator #34903

Merged
merged 1 commit into from Dec 9, 2019

Conversation

@weaverryan
Copy link
Member

weaverryan commented Dec 9, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets None
License MIT
Doc PR not needed

Hi!

Reported by a user on SymfonyCasts :). Apparently without the parentheses, the order of operations is incorrect: https://3v4l.org/UZ7GU

Thanks!

@yceruto
yceruto approved these changes Dec 9, 2019
@yceruto

This comment has been minimized.

Copy link
Member

yceruto commented Dec 9, 2019

Thank you @weaverryan.

yceruto added a commit that referenced this pull request Dec 9, 2019
…or (weaverryan)

This PR was merged into the 4.4 branch.

Discussion
----------

Fixing bad order of operations with null coalescing operator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | None
| License       | MIT
| Doc PR        | not needed

Hi!

Reported by a user on SymfonyCasts :). Apparently without the parentheses, the order of operations is incorrect: https://3v4l.org/UZ7GU

Thanks!

Commits
-------

6291264 Fixing bad order of operations with null coalescing operator
@yceruto yceruto merged commit 6291264 into symfony:4.4 Dec 9, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
@weaverryan weaverryan deleted the weaverryan:fix-bad-order-operations branch Dec 9, 2019
This was referenced Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.