Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] fix casting responses to PHP streams #35195

Merged
merged 1 commit into from Jan 4, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 3, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This patch is required to properly deal with casting responses to PHP streams.
This changes a public method, but we can't expect anyone to override it as it's totally internal.
Found when working on (and required by) #35115

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jan 3, 2020
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-stream-fix branch 2 times, most recently from e86dcfa to 81b50b5 Jan 3, 2020
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-stream-fix branch from 81b50b5 to 35c08ef Jan 3, 2020
@Nek-

This comment has been minimized.

Copy link
Contributor

Nek- commented Jan 4, 2020

I think it will also help to solve this: #35187 (comment)

nicolas-grekas added a commit that referenced this pull request Jan 4, 2020
…-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix casting responses to PHP streams

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This patch is required to properly deal with casting responses to PHP streams.
This changes a public method, but we can't expect anyone to override it as it's totally internal.
Found when working on (and required by) #35115

Commits
-------

35c08ef [HttpClient] fix casting responses to PHP streams
@nicolas-grekas nicolas-grekas merged commit 35c08ef into symfony:4.4 Jan 4, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-stream-fix branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.