Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] DecoratorServicePass should keep container.service_locator on the decorated definition #35214

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 4, 2020

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33670 (comment)
License MIT
Doc PR -

container.service_locator is special because it tells how the arguments of the constructor should be interpreted.

/cc @malarzm

…e decorated definition
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Jan 6, 2020

Thank you @malarzm.

nicolas-grekas added a commit that referenced this pull request Jan 6, 2020
…cator on the decorated definition (malarzm)

This PR was merged into the 4.3 branch.

Discussion
----------

[DI] DecoratorServicePass should keep container.service_locator on the decorated definition

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33670 (comment)
| License       | MIT
| Doc PR        | -

`container.service_locator` is special because it tells how the arguments of the constructor should be interpreted.

/cc @malarzm

Commits
-------

99dab87 [DI] DecoratorServicePass should keep container.service_locator on the decorated definition
@nicolas-grekas nicolas-grekas merged commit 99dab87 into symfony:4.3 Jan 6, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@malarzm

This comment has been minimized.

Copy link
Contributor

malarzm commented Jan 6, 2020

Thank you for taking the time to fix this @nicolas-grekas! 🍻

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-decorate-locator branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.