Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Fix collecting traceable listeners info on lazy firewalls #35240

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@chalasr
Copy link
Member

chalasr commented Jan 7, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Before:
Screenshot 2020-01-07 at 05 17 47

After:
Screenshot 2020-01-07 at 05 18 12

@chalasr chalasr added this to the 4.4 milestone Jan 7, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 7, 2020

I think this breaks laziness of the listeners: LazyFirewallContext won't see $listener instanceof AbstractListener anymore, isn't it?

@chalasr chalasr force-pushed the chalasr:debug-sec-listeners branch 3 times, most recently from 25ee2ea to 8835188 Jan 7, 2020
@chalasr

This comment has been minimized.

Copy link
Member Author

chalasr commented Jan 7, 2020

@nicolas-grekas ofc you're right. Should be better now

@chalasr chalasr force-pushed the chalasr:debug-sec-listeners branch 2 times, most recently from 4af5638 to 6b7d2d3 Jan 7, 2020
@chalasr chalasr force-pushed the chalasr:debug-sec-listeners branch from 6b7d2d3 to a3a9a0e Jan 9, 2020
@fabpot
fabpot approved these changes Jan 10, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 10, 2020

Thank you @chalasr.

fabpot added a commit that referenced this pull request Jan 10, 2020
…n lazy firewalls (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[SecurityBundle] Fix collecting traceable listeners info on lazy firewalls

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Before:
![Screenshot 2020-01-07 at 05 17 47](https://user-images.githubusercontent.com/7502063/71869007-cbffd400-3110-11ea-86ad-234da28621c4.png)

After:
![Screenshot 2020-01-07 at 05 18 12](https://user-images.githubusercontent.com/7502063/71869014-d9b55980-3110-11ea-8efc-1f1b16b2c372.png)

Commits
-------

a3a9a0e [SecurityBundle] Fix collecting traceable listeners info using anonymous: lazy
@fabpot fabpot merged commit a3a9a0e into symfony:4.4 Jan 10, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@chalasr chalasr deleted the chalasr:debug-sec-listeners branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.