Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Sort the KernelEvents constants #35248

Closed

Conversation

@hermann8u
Copy link

hermann8u commented Jan 7, 2020

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Hi,

When I need to visualize all the kernel events I often open the KernelEvents file. However, it is difficult to navigate through it because the constants are not in the same order compared to the framework execution life cycle.

This PR aims to sort this constants to match it. It's also the same order used in this documentation page.

Thanks.

@hermann8u hermann8u changed the title Sort the KernelEvents constants [HttpKernel] Sort the KernelEvents constants Jan 7, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 7, 2020

As this is not a bug fix, it should be done on master.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jan 7, 2020
@hermann8u

This comment has been minimized.

Copy link
Author

hermann8u commented Jan 8, 2020

Is this ok finally on 3.4 branch or should I rebase?

Moreover, be aware that there will be a merge conflict for branch >= 4.3 because the event class in annotations @event changed.

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 8, 2020

I didn't change my mind. That's for master.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 9, 2020

@hermann8u can you please resubmit for master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.