Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Document the router.cache_class_prefix parameter removal #35263

Merged

Conversation

@fancyweb
Copy link
Contributor

fancyweb commented Jan 8, 2020

Q A
Branch? 5.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

I use this parameter in one of my project. It was removed but it was not documented.

@@ -243,6 +243,7 @@ FrameworkBundle
* Removed `routing.loader.service`.
* Added support for PHPUnit 8. A `void` return-type was added to the `KernelTestCase::tearDown()` and `WebTestCase::tearDown()` method.
* Removed the `lock.store.flock`, `lock.store.semaphore`, `lock.store.memcached.abstract` and `lock.store.redis.abstract` services.
* Removed the `router.cache_class_prefix` parameter.

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jan 8, 2020

Member

this line is for 4.4 :)

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jan 8, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 8, 2020

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Jan 8, 2020
… parameter removal (fancyweb)

This PR was merged into the 5.0 branch.

Discussion
----------

[FrameworkBundle] Document the router.cache_class_prefix parameter removal

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I use this parameter in one of my project. It was removed but it was not documented.

Commits
-------

add10df [FrameworkBundle] Document the router.cache_class_prefix parameter removal
@nicolas-grekas nicolas-grekas merged commit add10df into symfony:5.0 Jan 8, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details
@fancyweb fancyweb deleted the fancyweb:routing-document-removed-param branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.