Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] - update @throws phpdoc #35265

Merged
merged 1 commit into from Jan 9, 2020
Merged

Conversation

@youssefbenhssaien
Copy link

youssefbenhssaien commented Jan 8, 2020

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR

Update PHPDoc throws Exceptions on https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Process/Process.php

* @throws RuntimeException When process stopped after receiving signal
* @throws LogicException When process is not yet started
* @throws ProcessTimedOutException When process timed out
* @throws ProcessTimedOutException When process stopped after receiving signal

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jan 8, 2020

Member

ProcessSignaledException?

This comment has been minimized.

Copy link
@youssefbenhssaien

youssefbenhssaien Jan 9, 2020

Author

Changed to ProcessTimedOutException

* @throws LogicException When process is not yet started
* @throws ProcessTimedOutException When process timed out
* @throws ProcessTimedOutException When process stopped after receiving signal
* @throws LogicException When process is not yet started

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jan 8, 2020

Member

\LogicException

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jan 8, 2020

Member

but actually the \ should be removed from the code, and this one kept as is

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jan 8, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 8, 2020

(for 4.3)

@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 4.3 Jan 9, 2020
@nicolas-grekas nicolas-grekas force-pushed the youssefbenhssaien:process branch from cf656e9 to 6df9843 Jan 9, 2020
@nicolas-grekas nicolas-grekas force-pushed the youssefbenhssaien:process branch from 6df9843 to 2be7029 Jan 9, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 9, 2020

Thank you @youssefbenhssaien.

nicolas-grekas added a commit that referenced this pull request Jan 9, 2020
This PR was merged into the 4.3 branch.

Discussion
----------

[Process] - update @throws phpdoc

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        |

Update PHPDoc throws Exceptions on https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Process/Process.php

Commits
-------

2be7029 [Process] - update @throws phpdoc
@nicolas-grekas nicolas-grekas merged commit 2be7029 into symfony:4.3 Jan 9, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.