Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Adding better output to secrets:decrypt-to-local command #35285

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@weaverryan
Copy link
Member

weaverryan commented Jan 9, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets none
License MIT
Doc PR not needed

Hi!

The secrets:decrypt-to-local doesn't give any output. This adds some basic details:

Screen Shot 2020-01-09 at 11 53 54 AM

(note the -vvv wasn't necessary in the command to show the output). And the <info>part is fixed.

Cheers!

@weaverryan weaverryan force-pushed the weaverryan:secrets-decrypt-local-output branch from 5039b27 to 4b59267 Jan 9, 2020
@weaverryan weaverryan force-pushed the weaverryan:secrets-decrypt-local-output branch from 4b59267 to a6aa978 Jan 10, 2020
@fabpot
fabpot approved these changes Jan 10, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 10, 2020

Thank you @weaverryan.

fabpot added a commit that referenced this pull request Jan 10, 2020
…ypt-to-local command (weaverryan)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[FrameworkBundle] Adding better output to secrets:decrypt-to-local command

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | not needed

Hi!

The `secrets:decrypt-to-local` doesn't give any output. This adds some basic details:

<img width="1280" alt="Screen Shot 2020-01-09 at 11 53 54 AM" src="https://user-images.githubusercontent.com/121003/72087704-ebe0f480-32d6-11ea-950c-c698abde783d.png">

(note the `-vvv` wasn't necessary in the command to show the output). And the `<info>`part is fixed.

Cheers!

Commits
-------

a6aa978 Adding better output to secrets:decrypt-to-local command
@fabpot fabpot merged commit a6aa978 into symfony:master Jan 10, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@weaverryan weaverryan deleted the weaverryan:secrets-decrypt-local-output branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.