Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upgrading instructions for deprecated router options #35297

Merged
merged 1 commit into from Jan 11, 2020

Conversation

@flack
Copy link
Contributor

flack commented Jan 10, 2020

See #30249 (comment)

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets #30249
License MIT
Doc PR
UPGRADE-5.0.md Outdated Show resolved Hide resolved
@flack flack force-pushed the flack:patch-1 branch from ff7cb8e to 2cc7083 Jan 10, 2020
@flack flack changed the base branch from master to 4.4 Jan 10, 2020
@fabpot
fabpot approved these changes Jan 11, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 11, 2020

Thank you @flack.

fabpot added a commit that referenced this pull request Jan 11, 2020
…ions (flack)

This PR was merged into the 4.4 branch.

Discussion
----------

Improve upgrading instructions for deprecated router options

See #30249 (comment)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | #30249
| License       | MIT
| Doc PR        |

Commits
-------

2cc7083 Improve upgrading instructions for deprecated router options
@fabpot fabpot merged commit 2cc7083 into symfony:4.4 Jan 11, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
fabbot.io Doing some proofreading and checking your coding style.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.