Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Deprecate *not* setting the "framework.router.utf8" option #35310

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 11, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? yes
Tickets -
License MIT
Doc PR -

The goal here is to get rid of the config/packages/routing.yaml file in Symfony 6.
This should have no practical impact as all new apps already define this setting for 2 years.

@fabpot
fabpot approved these changes Jan 12, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 12, 2020

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Jan 12, 2020
…rk.router.utf8" option (nicolas-grekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[FrameworkBundle] Deprecate *not* setting the "framework.router.utf8" option

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | -
| License       | MIT
| Doc PR        | -

The goal here is to get rid of the `config/packages/routing.yaml` file in Symfony 6.
This should have no practical impact as all new apps already define this setting for 2 years.

Commits
-------

84849bc [FrameworkBundle] Deprecate *not* setting the "framework.router.utf8" option
@fabpot fabpot merged commit 84849bc into symfony:master Jan 12, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:utf8-deprec branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.