Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Make many internal services as hidden #35321

Merged
merged 1 commit into from Jan 13, 2020
Merged

Conversation

@lyrixx
Copy link
Member

lyrixx commented Jan 13, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #35197
License MIT
Doc PR

I "removed":

  • transitions
  • auto-generated guard listener (when enable via the configuration)
  • auto-generated audit trail listener (when enable via the configuration)

I kept

  • the registry
  • the workflow (of course)
  • its definition: I know people are using it
  • workflow.twig_extension the twig extension because all others twig extensions are not hidden - but could IMHO
  • the default marking store
  • the command to dump the workflow (SVG)
  • The local expression language
  • abstract workflow definition for the workflow and state machine
@nicolas-grekas nicolas-grekas added this to the next milestone Jan 13, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Jan 13, 2020

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

@lyrixx

This comment has been minimized.

Copy link
Member Author

lyrixx commented Jan 13, 2020

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

I don't know. You tell me :)

@lyrixx lyrixx force-pushed the lyrixx:w-hidden branch from 023c8d7 to 79c85cb Jan 13, 2020
@lyrixx lyrixx force-pushed the lyrixx:w-hidden branch from 79c85cb to b4776d6 Jan 13, 2020
@lyrixx

This comment has been minimized.

Copy link
Member Author

lyrixx commented Jan 13, 2020

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

reverted

@fabpot
fabpot approved these changes Jan 13, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 13, 2020

Thank you @lyrixx.

fabpot added a commit that referenced this pull request Jan 13, 2020
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Workflow] Make many internal services as hidden

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #35197
| License       | MIT
| Doc PR        |

I "removed":

* transitions
* auto-generated guard listener  (when enable via the configuration)
* auto-generated audit trail listener (when enable via the configuration)
* abstract workflow definition for the workflow and state machine

I kept
* the registry
* the workflow (of course)
* its definition: I know people are using it
* `workflow.twig_extension` the twig extension because all others twig extensions are not hidden - but could IMHO
* the default marking store
* the command to dump the workflow (SVG)
* The local expression language

Commits
-------

b4776d6 [Workflow] Make many internal services as hidden
@fabpot fabpot merged commit b4776d6 into symfony:master Jan 13, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@lyrixx lyrixx deleted the lyrixx:w-hidden branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.