Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] allow using public aliases to reference controllers #35560

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 2, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

This PR allows referencing a controller with an alias when needed. The use case I'm targetting is using @Route annotations on methods of the App\Kernel and have them work. This PR allows it.

Sidekick of symfony/recipes#735

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:controller-alias branch from bffdae2 to 94bc1f7 Feb 2, 2020
@yceruto
yceruto approved these changes Feb 2, 2020
@fabpot
fabpot approved these changes Feb 3, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 3, 2020

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Feb 3, 2020
…ontrollers (nicolas-grekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpKernel] allow using public aliases to reference controllers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This PR allows referencing a controller with an alias when needed. The use case I'm targetting is using `@Route` annotations on methods of the `App\Kernel` and have them work. This PR allows it.

Sidekick of symfony/recipes#735

Commits
-------

94bc1f7 [HttpKernel] allow using public aliases to reference controllers
@fabpot fabpot merged commit 94bc1f7 into symfony:master Feb 3, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:controller-alias branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.