Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console][QuestionHelper] Use String width() to properly move the cursor backwards #35578

Merged
merged 1 commit into from Feb 11, 2020

Conversation

@fancyweb
Copy link
Contributor

fancyweb commented Feb 3, 2020

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets #35536 (comment)
License MIT
Doc PR -

This bug can only be fixed on master since we need to require the String component. Once the component is required, we can iterate in the Console component to use it more where it is needed.

@chalasr chalasr added this to the next milestone Feb 3, 2020
@fancyweb fancyweb changed the title [Console][QuestionHelper] Use String width() to properly move the cursor backwards [WIP][Console][QuestionHelper] Use String width() to properly move the cursor backwards Feb 6, 2020
fabpot added a commit that referenced this pull request Feb 7, 2020
This PR was merged into the 5.1-dev branch.

Discussion
----------

[String] Remove the @experimental status

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #35578 (comment)
| License       | MIT
| Doc PR        | -

Commits
-------

3d15f91 [String] Remove the @experimental status
nicolas-grekas added a commit that referenced this pull request Feb 7, 2020
This PR was merged into the 5.1-dev branch.

Discussion
----------

[String] Add the s() helper method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | #35578 (comment)
| License       | MIT
| Doc PR        | -

This method will be useful in our code base, and to anyone that doesn't really understand the differences between UnicodeString and ByteString.

Commits
-------

659cdf1 [String] Add the s() helper method
@fancyweb fancyweb force-pushed the fancyweb:console-use-string-component branch from cd34a17 to 67a1f55 Feb 10, 2020
@nicolas-grekas nicolas-grekas changed the title [WIP][Console][QuestionHelper] Use String width() to properly move the cursor backwards [Console][QuestionHelper] Use String width() to properly move the cursor backwards Feb 11, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 11, 2020

Thank you @fancyweb.

fabpot added a commit that referenced this pull request Feb 11, 2020
…ove the cursor backwards (fancyweb)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Console][QuestionHelper] Use String width() to properly move the cursor backwards

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #35536 (comment)
| License       | MIT
| Doc PR        | -

This bug can only be fixed on master since we need to require the String component. Once the component is required, we can iterate in the Console component to use it more where it is needed.

Commits
-------

67a1f55 [Console][QuestionHelper] Use String width() to properly move the cursor backwards
@fabpot fabpot merged commit 67a1f55 into symfony:master Feb 11, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@fancyweb fancyweb deleted the fancyweb:console-use-string-component branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.