Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] fix getting the vendor/ dir for tests #35601

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 5, 2020

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Feb 5, 2020
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-deprec branch from 2fff578 to 095e360 Feb 5, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Feb 5, 2020

@l-vo @greg0ire could you please have a look at the remaining failures?

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-deprec branch 2 times, most recently from d85e080 to 32926cf Feb 5, 2020
@nicolas-grekas nicolas-grekas changed the base branch from master to 4.4 Feb 5, 2020
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-deprec branch from 32926cf to 341dd5d Feb 5, 2020
nicolas-grekas added a commit that referenced this pull request Feb 5, 2020
…icolas-grekas)

This PR was submitted for the master branch but it was merged into the 4.4 branch instead.

Discussion
----------

[PhpUnitBridge] fix getting the vendor/ dir for tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

341dd5d [PhpUnitBridge] fix getting the vendor/ dir for tests
@nicolas-grekas nicolas-grekas merged commit 341dd5d into symfony:4.4 Feb 5, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-deprec branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.