Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Make method signature compatible with 4.4 #35616

Merged
merged 1 commit into from Feb 6, 2020
Merged

Conversation

@pbowyer
Copy link
Contributor

pbowyer commented Feb 6, 2020

Q A
Branch? 5.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35615
License MIT
Doc PR symfony/symfony-docs#...

A method signature changed in a non-backwards-compatible way in 5.0.0 - and in only one class. This commit fixes that - and has been tested.

For full details see ticket #35615.

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Feb 6, 2020
@lyrixx
lyrixx approved these changes Feb 6, 2020
@lyrixx lyrixx force-pushed the pbowyer:patch-2 branch from eb8db93 to 474be96 Feb 6, 2020
@lyrixx

This comment has been minimized.

Copy link
Member

lyrixx commented Feb 6, 2020

Good catch, thanks Peter.

lyrixx added a commit that referenced this pull request Feb 6, 2020
…yer)

This PR was squashed before being merged into the 5.0 branch (closes #35616).

Discussion
----------

[Workflow] Make method signature compatible with 4.4

| Q             | A
| ------------- | ---
| Branch?       | 5.0 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #35615  <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->
A method signature changed in a non-backwards-compatible way in 5.0.0 - and in only one class. This commit fixes that - and has been tested.

For full details see ticket #35615.

Commits
-------

474be96 [Workflow] Make method signature compatible with 4.4
@lyrixx lyrixx merged commit 474be96 into symfony:5.0 Feb 6, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.