Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] throw when PhpProcess::fromShellCommandLine() is used #35641

Merged
merged 1 commit into from Feb 8, 2020

Conversation

@Guikingone
Copy link
Contributor

Guikingone commented Feb 7, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35637
License MIT
Doc PR None

Close #35638

Final PR (rebased and tests added)

@Guikingone Guikingone force-pushed the Guikingone:fix/process branch 2 times, most recently from e226513 to 2551847 Feb 7, 2020
@Guikingone

This comment has been minimized.

Copy link
Contributor Author

Guikingone commented Feb 7, 2020

Maybe it could be a good idea to submit a PR on the doc to add a warning about calling this method? 🤔

@Guikingone Guikingone force-pushed the Guikingone:fix/process branch from 2551847 to 7f6d71c Feb 7, 2020
@nicolas-grekas nicolas-grekas changed the title [Process] PhpProcess::fromShellCommandLine [Process] throw when PhpProcess::fromShellCommandLine() is used Feb 7, 2020
@nicolas-grekas nicolas-grekas linked an issue that may be closed by this pull request Feb 7, 2020
@fabpot
fabpot approved these changes Feb 8, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 8, 2020

Thank you @Guikingone.

fabpot added a commit that referenced this pull request Feb 8, 2020
… used (Guikingone)

This PR was merged into the 4.4 branch.

Discussion
----------

[Process] throw when PhpProcess::fromShellCommandLine() is used

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35637
| License       | MIT
| Doc PR        | None

Close #35638

Final PR (rebased and tests added)

Commits
-------

7f6d71c refactor(Process): fromShellCommandLine
@fabpot fabpot merged commit 7f6d71c into symfony:4.4 Feb 8, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.