Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contracts] Split the global CHANGELOG in dedicated CHANGELOG per contract #35663

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@lyrixx
Copy link
Member

lyrixx commented Feb 10, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This is more in sync with what we do with other components + bundles.
And when we contribute to a contact, it's easier to find the file (because with the substree, we don't get the global package)

@nicolas-grekas nicolas-grekas changed the title [Constracts] Split the global CHANGELOG in dedicated CHANGELOG per contract [Contracts] Split the global CHANGELOG in dedicated CHANGELOG per contract Feb 10, 2020
@nicolas-grekas nicolas-grekas added this to the next milestone Feb 10, 2020
@fabpot
fabpot approved these changes Feb 10, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 10, 2020

Thank you @lyrixx.

fabpot added a commit that referenced this pull request Feb 10, 2020
…GELOG per contract (lyrixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Contracts] Split the global CHANGELOG in dedicated CHANGELOG per contract

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

---

This is more in sync with what we do with other components + bundles.
And when we contribute to a contact, it's easier to find the file (because with the substree, we don't get the global package)

Commits
-------

a05ee08 [Constracts] Split the global CHANGELOG in dedicated CHANGELOG per contract
@fabpot fabpot merged commit a05ee08 into symfony:master Feb 10, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@lyrixx lyrixx deleted the lyrixx:contracts-changelog branch Feb 10, 2020
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Feb 13, 2020
… dedicated CHANGELOG per contract (lyrixx)"

This reverts commit a9eec71, reversing
changes made to 033ec1b.
fabpot added a commit that referenced this pull request Feb 14, 2020
… contracts (nicolas-grekas)

This PR was squashed before being merged into the 5.1-dev branch.

Discussion
----------

[symfony/contracts] Reference one main CHANGELOG in each contracts

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Reverts #35663
This PR makes it easier to publish the changelog for the contracts: there is only one to reference. We also need a changelog for symfony/contracts and this PR fixes this concern.

Commits
-------

d6fa13b [symfony/contracts] Reference one main CHANGELOG in each contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.