Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DomCrawler] Rename UriExpander.php -> UriResolver #35667

Merged
merged 1 commit into from Feb 11, 2020

Conversation

@lyrixx
Copy link
Member

lyrixx commented Feb 10, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets refs symfony/symfony-docs#13054 (comment)
License MIT
Doc PR symfony/symfony-docs#13054 // don't open a new issue in doc repo
@lyrixx lyrixx force-pushed the lyrixx:dom-crawler-resolve branch from ba30cb1 to a52736b Feb 10, 2020
@@ -5,7 +5,7 @@ CHANGELOG
-----

* Added an internal cache layer on top of the CssSelectorConverter
* Added `UriExpander` to expand an URL according to another URL
* Added `UriResolved` to resolve an URI according to a base URI

This comment has been minimized.

Copy link
@ro0NL

ro0NL Feb 10, 2020

Contributor

UriResolver :)

{
/**
* Expand an URI according to a current Uri.
* Resolve an URI according to a base URI.

This comment has been minimized.

Copy link
@OskarStark

OskarStark Feb 10, 2020

Contributor

ResolveS

@fabpot
fabpot approved these changes Feb 11, 2020
@fabpot fabpot force-pushed the lyrixx:dom-crawler-resolve branch from a52736b to 3217f81 Feb 11, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 11, 2020

Thank you @lyrixx.

fabpot added a commit that referenced this pull request Feb 11, 2020
…rixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[DomCrawler] Rename UriExpander.php -> UriResolver

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | refs symfony/symfony-docs#13054 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#13054 // don't open a new issue in doc repo

Commits
-------

3217f81 [DomCrawler] Rename UriExpander.php -> UriResolver
@fabpot fabpot merged commit 3217f81 into symfony:master Feb 11, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@lyrixx lyrixx deleted the lyrixx:dom-crawler-resolve branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.