Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExpressionLanguage] Fixed collisions of character operators with object properties #35707

Open
wants to merge 1 commit into
base: 4.4
from

Conversation

@Andrej-in-ua
Copy link

Andrej-in-ua commented Feb 13, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

Expression foo.not in [bar] compiles to invalid php code:

$foo->not in[$bar]

Added check for absence of a dot before of the character operators.

PS. I apologize for not starting the issue before create PR. I considered this bug is minor, but obvious.

@Andrej-in-ua Andrej-in-ua force-pushed the Andrej-in-ua:fix-expression-lexer-operator-4.4 branch from b7c4160 to 60868aa Feb 13, 2020
@Andrej-in-ua Andrej-in-ua force-pushed the Andrej-in-ua:fix-expression-lexer-operator-4.4 branch from 60868aa to 2b3d8e0 Feb 13, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 15, 2020

I suppose the same issue exists on 3.4? Can you please rebase+retarget the PR if confirmed?

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.