Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ErrorHandler] silence warning when zend.assertions=-1 #35710

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 13, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Reported at symfony/orm-pack@1000287#commitcomment-37276894

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Feb 13, 2020
nicolas-grekas referenced this pull request in symfony/orm-pack Feb 13, 2020
@blry

This comment has been minimized.

Copy link

blry commented Feb 13, 2020

Hi @nicolas-grekas. This issue appears also in Symfony 5

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Feb 13, 2020

We merge lower branches into upper ones periodically.

@fabpot
fabpot approved these changes Feb 14, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 14, 2020

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Feb 14, 2020
…colas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler] silence warning when zend.assertions=-1

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Reported at symfony/orm-pack@1000287#commitcomment-37276894

Commits
-------

67ef532 [ErrorHandler] silence warning when zend.assertions=-1
@fabpot fabpot merged commit 67ef532 into symfony:4.4 Feb 14, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:eh-silence branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.