Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Correctly remove trace level options for HttpCache #35714

Merged
merged 1 commit into from Feb 15, 2020

Conversation

@aschempp
Copy link
Contributor

aschempp commented Feb 14, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The HttpCache component allows to configure a trace level. Due to the behavior of CachingHttpClient, options that are meant for the HttpCache must be unset before preparing the request. Currently these options can't be set, because HttpClient errors with invalid configuration options.

@aschempp aschempp changed the title Correctly remove trace level options for HttpCache [HttpClient] Correctly remove trace level options for HttpCache Feb 14, 2020
@nicolas-grekas nicolas-grekas changed the base branch from master to 4.4 Feb 14, 2020
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Feb 14, 2020
@fabpot
fabpot approved these changes Feb 15, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 15, 2020

Thank you @aschempp.

fabpot added a commit that referenced this pull request Feb 15, 2020
…Cache (aschempp)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Correctly remove trace level options for HttpCache

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The `HttpCache` component allows to [configure a trace level](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php#L46). Due to the behavior of `CachingHttpClient`, options that are meant for the `HttpCache` must be unset before preparing the request. Currently these options can't be set, because `HttpClient` errors with invalid configuration options.

Commits
-------

618cd80 Correctly remove trace level options for HttpCache
@fabpot fabpot merged commit 618cd80 into symfony:4.4 Feb 15, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@aschempp aschempp deleted the aschempp:bugfix/trace-http-client branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.