Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] ignore microseconds submitted by Edge #36020

Merged
merged 1 commit into from Mar 13, 2020
Merged

Conversation

@xabbuh
Copy link
Member

xabbuh commented Mar 10, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35989
License MIT
Doc PR
@xabbuh xabbuh added this to the 3.4 milestone Mar 10, 2020
@xabbuh xabbuh force-pushed the xabbuh:issue-35989 branch from 3c84356 to 905be49 Mar 10, 2020
@xabbuh xabbuh force-pushed the xabbuh:issue-35989 branch from 905be49 to f9c474a Mar 13, 2020
@xabbuh xabbuh force-pushed the xabbuh:issue-35989 branch from f9c474a to 20971df Mar 13, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 13, 2020

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit a562ba2 into symfony:3.4 Mar 13, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@xabbuh xabbuh deleted the xabbuh:issue-35989 branch Mar 13, 2020
fabpot added a commit that referenced this pull request Mar 15, 2020
… merge conflict) (wouterj)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[DI][Form] Fixed test suite (TimeType changes & unresolved merge conflict)

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

After the merge of #36020 , the `addViewTransformer()` was moved to the top of the statement. This is wrong, as the `$format` variable is changed when a `reference_date` is set (see line 77). This broke Symfony's testsuite :)

Commits
-------

18f5b17 [DI][Form] Fixed test suite (TimeType changes & unresolved merge conflict)
This was referenced Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.