Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] clarify stringable type annotations #36057

Merged
merged 1 commit into from Mar 13, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 13, 2020

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 13, 2020
@nicolas-grekas nicolas-grekas merged commit cbb9d01 into symfony:3.4 Mar 13, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:stringable-only branch Mar 13, 2020
@DavidBadura

This comment has been minimized.

Copy link
Contributor

DavidBadura commented Apr 2, 2020

In our projects psalm complains that the \Stringable class has not been seen. We fixed it by installing the PHP80 polyfill. Shouldn't you add it as a composer require when using it?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Apr 2, 2020

I considered that but that's not a requirement of the code, so it's not needed. If it's a requirement for you because of the tooling you use, this is legit and then you should add the polyfill.

@DavidBadura

This comment has been minimized.

Copy link
Contributor

DavidBadura commented Apr 2, 2020

Yes, I was also unsure, but you are right. The code doesn't need it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.