Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uid] improve base convertion logic #36070

Merged
merged 1 commit into from Mar 14, 2020
Merged

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 14, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

The new logic is at least twice as fast as the current algo.
It's also way more common and generic.

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 14, 2020
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:uuid-base branch from d85653f to 8c79ece Mar 14, 2020
nicolas-grekas added a commit to symfony/polyfill that referenced this pull request Mar 14, 2020
…icolas-grekas)

This PR was merged into the 1.15-dev branch.

Discussion
----------

[uuid] improve base convertion logic for 32-bit systems

Similar to symfony/symfony#36070

Commits
-------

9d449a9 [uuid] improve base convertion logic for 32-bit systems
*
* @author Nicolas Grekas <p@tchwork.com>
*/
class BinaryUtil

This comment has been minimized.

Copy link
@javiereguiluz

javiereguiluz Mar 14, 2020

Member

Even if it's a utility class, should we add explicit tests for it?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 14, 2020

Author Member

It's already tested since we use the code in Uuid and Ulid.
If someone whishes to contribute more specific tests, PR welcome.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:uuid-base branch from 8c79ece to 7e1cff1 Mar 14, 2020
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:uuid-base branch from 7e1cff1 to 0e05c6d Mar 14, 2020
@nicolas-grekas nicolas-grekas merged commit fa5d636 into symfony:master Mar 14, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:uuid-base branch Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.