Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uid] work around slow generation of v4 UUIDs #36078

Merged
merged 1 commit into from Mar 15, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 15, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This is more than 4 times faster than uuid_create() for v4.
As described in https://jolicode.com/blog/uuid-generation-in-php

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 15, 2020
@fabpot
fabpot approved these changes Mar 15, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 15, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 00aab67 into symfony:master Mar 15, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:uuidv4-boost branch Mar 15, 2020
@stof

This comment has been minimized.

Copy link
Member

stof commented Mar 16, 2020

Should the polyfill use the same implementation ?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Mar 16, 2020

It uses a very similar one already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.