Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] fix side-effect by not using mt_rand() #36121

Merged
merged 1 commit into from Mar 18, 2020

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 17, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Reported by @bobthecow on Twitter: using mt_rand() breaks inspecting seeded calls to mt_rand().

Should be replaced by a call to md5(random_bytes(6)) on 4.4.

@fabpot
fabpot approved these changes Mar 18, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 18, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 5f364af into symfony:3.4 Mar 18, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@bobthecow

This comment has been minimized.

Copy link
Contributor

bobthecow commented Mar 18, 2020

Thanks for the quick fix, @nicolas-grekas!

@fabpot fabpot mentioned this pull request Mar 27, 2020
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:vd-mt_rand branch Mar 27, 2020
This was referenced Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.