Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][Routing] Add link to source to router:match #36144

Merged
merged 1 commit into from Mar 20, 2020

Conversation

@l-vo
Copy link
Contributor

l-vo commented Mar 19, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets https://github.com/orgs/symfony/projects/1#card-30505860
License MIT
Doc PR

Add link to source on debug:router/router:match when framework.ide is configured

Copy link
Member

nicolas-grekas left a comment

nice thanks

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md Outdated Show resolved Hide resolved
@l-vo l-vo force-pushed the l-vo:add_link_to_source_router_match branch 2 times, most recently from 8c674f5 to dad19bb Mar 19, 2020
@l-vo l-vo force-pushed the l-vo:add_link_to_source_router_match branch from dad19bb to 83b307a Mar 20, 2020
@l-vo

This comment has been minimized.

Copy link
Contributor Author

l-vo commented Mar 20, 2020

Added $this->formatValue to safely handle $defaults['_controller'] if not a string

@l-vo l-vo force-pushed the l-vo:add_link_to_source_router_match branch from 83b307a to b9cbd3d Mar 20, 2020
@l-vo l-vo force-pushed the l-vo:add_link_to_source_router_match branch from b9cbd3d to a96690c Mar 20, 2020
@fabpot
fabpot approved these changes Mar 20, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 20, 2020

Thank you @l-vo.

@fabpot fabpot merged commit 7e181b9 into symfony:master Mar 20, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@l-vo l-vo deleted the l-vo:add_link_to_source_router_match branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.