Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Support customized intl php.ini settings #36149

Merged
merged 1 commit into from Mar 23, 2020

Conversation

@jorrit
Copy link
Contributor

jorrit commented Mar 20, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no

IntlDateParser->parse() behaves differently when intl.error_level and/or intl.use_exceptions are not 0.

This change makes sure \IntlException is caught when intl.use_exceptions is 1 and warnings thrown when intl.error_level is not 0 are ignored.

@jorrit jorrit requested a review from xabbuh as a code owner Mar 20, 2020
@jorrit jorrit changed the base branch from master to 5.0 Mar 20, 2020
@jorrit jorrit force-pushed the jorrit:intlinisettings branch 2 times, most recently from ddc608e to 251aa20 Mar 20, 2020
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 20, 2020
@nicolas-grekas nicolas-grekas changed the title Support customized intl php.ini settings [Form] Support customized intl php.ini settings Mar 23, 2020
@jorrit jorrit force-pushed the jorrit:intlinisettings branch from 251aa20 to 2c5685d Mar 23, 2020
@nicolas-grekas nicolas-grekas changed the base branch from 5.0 to 3.4 Mar 23, 2020
@nicolas-grekas nicolas-grekas force-pushed the jorrit:intlinisettings branch from 2c5685d to 014259c Mar 23, 2020
`IntlDateParser->parse()` behaves differently when `intl.error_level` and/or `intl.use_exceptions` are not 0.

This change makes sure `\IntlException` is caught when `intl.use_exceptions` is 1 and warnings thrown when `intl.error_level` is not 0 are ignored.
@nicolas-grekas nicolas-grekas force-pushed the jorrit:intlinisettings branch from 014259c to 61025d1 Mar 23, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 23, 2020

Thank you @jorrit.

@nicolas-grekas nicolas-grekas merged commit 5b5b61f into symfony:3.4 Mar 23, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@jorrit

This comment has been minimized.

Copy link
Contributor Author

jorrit commented Mar 23, 2020

No problem @nicolas-grekas, thanks for merging!

@jorrit jorrit deleted the jorrit:intlinisettings branch Mar 23, 2020
This was referenced Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.