Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Dump kernel extension configuration #36186

Open
wants to merge 16 commits into
base: master
from

Conversation

@guillbdx
Copy link
Contributor

guillbdx commented Mar 24, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets #34756
License MIT

If the kernel is a container extension and defines a configuration, the config:dump-reference will now be able to dump it.

guillbdx added 2 commits Mar 24, 2020
@guillbdx guillbdx changed the title Fwb dump kernel extension configuration [FrameworkBundle] dump kernel extension configuration Mar 24, 2020
@guillbdx guillbdx changed the title [FrameworkBundle] dump kernel extension configuration [FrameworkBundle] Dump kernel extension configuration Mar 24, 2020
@nicolas-grekas nicolas-grekas added this to the next milestone Mar 24, 2020
@@ -70,6 +73,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int

if (null === $name = $input->getArgument('name')) {
$this->listBundles($errorIo);

$kernel = $this->getApplication()->getKernel();
if ($kernel->getAlias()

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 24, 2020

Member

shouldn't this call be after the instanceof check? (same in the other command)

This comment has been minimized.

Copy link
@guillbdx

guillbdx Mar 24, 2020

Author Contributor

Yes, done.

guillbdx added 4 commits Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.