Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] add German translations #36200

Merged
merged 1 commit into from Mar 27, 2020
Merged

[Validator] add German translations #36200

merged 1 commit into from Mar 27, 2020

Conversation

@xabbuh
Copy link
Member

xabbuh commented Mar 25, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR
@lyrixx

This comment has been minimized.

Copy link
Member

lyrixx commented Mar 25, 2020

IIRC, we should submit translations on older maintained branch (3.4 ATM), shouldn't?

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Mar 25, 2020

@lyrixx yes, @nicolas-grekas asked me to open it against master so that the PR can be used to demonstrate the translation process during the online conference on Friday

@fabpot fabpot changed the base branch from master to 3.4 Mar 27, 2020
@fabpot fabpot force-pushed the xabbuh:sync-translations branch from 81eda87 to 32d9a52 Mar 27, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 27, 2020

Thank you @xabbuh.

@fabpot fabpot merged commit 8f2d2c3 into symfony:3.4 Mar 27, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@xabbuh xabbuh deleted the xabbuh:sync-translations branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.