Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Fix TraceableHttpClient::stream that not works #36214

Merged
merged 1 commit into from Mar 27, 2020

Conversation

@l-vo
Copy link
Contributor

l-vo commented Mar 25, 2020

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

The stream method when using the TraceableHttpClient seems not work.

I'm not sure to really understand what the previous implementation should do but this is an attempt to fix it.

@l-vo l-vo force-pushed the l-vo:fix_stream_with_traceable_response branch from c505251 to 523a521 Mar 26, 2020
@l-vo l-vo force-pushed the l-vo:fix_stream_with_traceable_response branch from 523a521 to 68df30c Mar 26, 2020
@nicolas-grekas nicolas-grekas added this to the next milestone Mar 26, 2020
Copy link
Member

nicolas-grekas left a comment

(once fabbot's patch is applied)

@l-vo

This comment has been minimized.

Copy link
Contributor Author

l-vo commented Mar 26, 2020

(once fabbot's patch is applied)

It's a false positive; isn't it ?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 26, 2020

Not sure - at least it's not wrong to add the double quotes. Adding them will prevent this from being reported again and again.

@l-vo l-vo force-pushed the l-vo:fix_stream_with_traceable_response branch 2 times, most recently from 769e349 to 0ae205d Mar 26, 2020
@l-vo l-vo force-pushed the l-vo:fix_stream_with_traceable_response branch from 0ae205d to dcfbbb7 Mar 26, 2020
@fabpot fabpot force-pushed the l-vo:fix_stream_with_traceable_response branch from dcfbbb7 to 575f040 Mar 27, 2020
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 27, 2020

Thank you @l-vo.

@fabpot fabpot merged commit e0de6cc into symfony:master Mar 27, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
fabbot.io Your code looks good.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.