Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer][Messenger] add return statement for MessageHandler #36424

merged 1 commit into from Apr 13, 2020


Copy link

ottaviano commented Apr 11, 2020

Branch? master
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR

By returning the result of the transporter in MessageHandler we can get hold of SentMessage from HandledStamp::getResult().

Copy link

nicolas-grekas commented Apr 12, 2020

Can you add a test case please? Did you have a look at other handlers that might need the same?

fabpot approved these changes Apr 13, 2020
Copy link

fabpot commented Apr 13, 2020

Thank you @ottaviano.

@fabpot fabpot merged commit 0933f90 into symfony:master Apr 13, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details Your code looks good.
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
@mbabker mbabker mentioned this pull request Jun 23, 2020
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.