[TwigBundle] Improved ExceptionController docblocks #3669

Merged
merged 3 commits into from Mar 23, 2012

Conversation

Projects
None yet
4 participants
@lencioni
Contributor

lencioni commented Mar 21, 2012

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: Build Status
Fixes the following tickets: -
Todo: -

@lencioni

This comment has been minimized.

Show comment Hide comment
@lencioni

lencioni Mar 21, 2012

Contributor

I obviously don't know what I'm doing here. :/

Contributor

lencioni commented Mar 21, 2012

I obviously don't know what I'm doing here. :/

@vicb

This comment has been minimized.

Show comment Hide comment
@vicb

vicb Mar 21, 2012

Contributor

no pb just rebase on master and force push

Contributor

vicb commented Mar 21, 2012

no pb just rebase on master and force push

[TwigBundle] Improved ExceptionController docblocks
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/lencioni/symfony.png)](http://travis-ci.org/lencioni/symfony)
Fixes the following tickets: -
Todo: -
@@ -74,6 +79,14 @@ protected function getAndCleanOutputBuffering()
return $currentContent;
}
+ /**
+ * @param Symfony\Bundle\TwigBundle\TwigEngine $templating

This comment has been minimized.

Show comment Hide comment
@fabpot

fabpot Mar 21, 2012

Member

You should add a use statement at the top of the file and just use the class name here.

@fabpot

fabpot Mar 21, 2012

Member

You should add a use statement at the top of the file and just use the class name here.

This comment has been minimized.

Show comment Hide comment
@vicb

vicb Mar 21, 2012

Contributor

should we typehint then ?

@vicb

vicb Mar 21, 2012

Contributor

should we typehint then ?

This comment has been minimized.

Show comment Hide comment
@fabpot

fabpot Mar 21, 2012

Member

no, not necessarily.

@fabpot

fabpot Mar 21, 2012

Member

no, not necessarily.

[TwigBundle] Added a use statement to shorten class name in a docblock
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/lencioni/symfony.png)](http://travis-ci.org/lencioni/symfony)
Fixes the following tickets: -
Todo: -
@@ -74,6 +80,14 @@ protected function getAndCleanOutputBuffering()
return $currentContent;
}
+ /**
+ * @param TwigEngine $templating

This comment has been minimized.

Show comment Hide comment
@stof

stof Mar 21, 2012

Member

You should mention the EngineInterface instead of the TwigEngine (if you are using multiple engines in your app, this method will receive the DelegatingEngine instead of the TwigEngine

@stof

stof Mar 21, 2012

Member

You should mention the EngineInterface instead of the TwigEngine (if you are using multiple engines in your app, this method will receive the DelegatingEngine instead of the TwigEngine

This comment has been minimized.

Show comment Hide comment
@lencioni

lencioni Mar 22, 2012

Contributor

Good call. Fixed.

@lencioni

lencioni Mar 22, 2012

Contributor

Good call. Fixed.

[TwigBundle] Made docblock for findTemplate() more general and accurate
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/lencioni/symfony.png)](http://travis-ci.org/lencioni/symfony)
Fixes the following tickets: -
Todo: -

fabpot added a commit that referenced this pull request Mar 23, 2012

merged branch lencioni/improve-exception-controller-documentation (PR #…
…3669)

Commits
-------

1422133 [TwigBundle] Made docblock for findTemplate() more general and accurate
5910ac9 [TwigBundle] Added a use statement to shorten class name in a docblock
3e7eebd [TwigBundle] Improved ExceptionController docblocks

Discussion
----------

[TwigBundle] Improved ExceptionController docblocks

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/lencioni/symfony.png)](http://travis-ci.org/lencioni/symfony)
Fixes the following tickets: -
Todo: -

---------------------------------------------------------------------------

by lencioni at 2012-03-21T20:47:16Z

I obviously don't know what I'm doing here. :/

---------------------------------------------------------------------------

by vicb at 2012-03-21T20:47:39Z

no pb just rebase on master and force push

@fabpot fabpot merged commit 1422133 into symfony:master Mar 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment