Translate failure messages of json authentication

[malteschlueter]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Resolves #33168
License	MIT
Doc PR	-

Until now the failure messages of the json authentication were not translated. I'm not sure if it's a bug or a new feature. The changes shouldn't be a BC.

[wouterj]

Thanks for working on this one. It's definitely a feature (so targetting master is a good idea).

I don't think we have to add this to the UsernamePasswordJsonAuthenticationListener (those are part of a system that will be removed in Symfony 6). If you can, I think it's also a good idea to add a test for this new feature.

[malteschlueter]

Thanks for working on this one. It's definitely a feature (so targetting master is a good idea).

My pleasure.

I don't think we have to add this to the UsernamePasswordJsonAuthenticationListener (those are part of a system that will be removed in Symfony 6). If you can, I think it's also a good idea to add a test for this new feature.

I will add a test. Takes some time^^

[malteschlueter]

During writing the test i saw some other error messages like "Invalid username." (JsonLoginAuthenticator.php#L167).
Am i blind or is there no translation for it?

What do you think about the other error messages. Should they also translated see "Invalid JSON." or "The key "username" must be provided."

[ro0NL]

i figure we can re-use a bunch of translations from the validator domain.

[ro0NL]

no wait, i dont think http exceptions need to be translated at all. Usually they are caught by an ExceptionListener exposing the http status text in prod (while preserving the original message in dev).

In this case im fine with only translating the responses generated here 👍

[wouterj]

Please note that the $message constructor is a non-user safe string and the messageKey is almost always hardcoded in the exception class. And this message key does exists:

symfony/src/Symfony/Component/Security/Core/Resources/translations/security.en.xlf

Lines 17 to 20 in 485e59f

	<trans-unit id="4">
	<source>Invalid credentials.</source>
	<target>Invalid credentials.</target>
	</trans-unit>

[xabbuh]

@malteschlueter looks like the PR already needs a rebase 🙈

[fabpot]

Thank you @malteschlueter.

[malteschlueter]

Thanks for merging @fabpot. It was a little bit too fast^^
I missed to add some tests. I've done it here #38044 now. :)