use a PHP 8 compatible Composer version #38113
Conversation
xabbuh
commented
Sep 8, 2020
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
|
using a version of Composer that includes composer/composer#9183 will make tests of the ErrorHandler component pass |
.travis.yml
Outdated
| @@ -196,6 +196,8 @@ before_install: | |||
| ldapadd -h localhost:3389 -D cn=admin,dc=symfony,dc=com -w symfony -f src/Symfony/Component/Ldap/Tests/Fixtures/data/fixtures.ldif | |||
| fi | |||
|
|
|||
| - if [[ $PHP = nightly ]]; then composer self-update --snapshot --1; fi | |||
There was a problem hiding this comment.
passing both --snapshot and --1 is useless. There is a single snapshot channel (and it is now about composer 2). --1 means using the stable channel but restricted to 1.x versions.
There was a problem hiding this comment.
if you pass multiple options, the first one will win in the order specified in https://github.com/composer/composer/blob/c6d0309d48e57c8e9a46988bd71d34c4079256a6/src/Composer/SelfUpdate/Versions.php#L24
There was a problem hiding this comment.
see composer/composer#9189 for a discussion on Composer about having a snapshot of 1.x
|
Also, nothing actually works in the PHP nightly job, because composer complains about a missing |
this might be related to using composer 2 rather than composer 1, but this might indicate a behavior difference. |
xabbuh
force-pushed
the
php8-error-handler
branch
from
c328cbe
to
ce5f428
Compare
