[Form] Fixed documentation, and the DateType (default options) #3880

Merged
merged 2 commits into from Apr 11, 2012

Conversation

Projects
None yet
2 participants
@willdurand
Contributor

willdurand commented Apr 11, 2012

No description provided.

@fabpot

This comment has been minimized.

Show comment Hide comment
@fabpot

fabpot Apr 11, 2012

Member

That breaks the tests.

Member

fabpot commented Apr 11, 2012

That breaks the tests.

@willdurand

This comment has been minimized.

Show comment Hide comment
@willdurand

willdurand Apr 11, 2012

Contributor

I got an error with the Form test suite before to write this patch..

Contributor

willdurand commented Apr 11, 2012

I got an error with the Form test suite before to write this patch..

@willdurand

This comment has been minimized.

Show comment Hide comment
@willdurand

willdurand Apr 11, 2012

Contributor

Nevermind, I can see broken tests.. I'm on, sorry

Contributor

willdurand commented Apr 11, 2012

Nevermind, I can see broken tests.. I'm on, sorry

@willdurand

This comment has been minimized.

Show comment Hide comment
@willdurand

willdurand Apr 11, 2012

Contributor

@fabpot fixed.

OK, but incomplete or skipped tests!
Tests: 945, Assertions: 1439, Incomplete: 11.
Contributor

willdurand commented Apr 11, 2012

@fabpot fixed.

OK, but incomplete or skipped tests!
Tests: 945, Assertions: 1439, Incomplete: 11.

fabpot added a commit that referenced this pull request Apr 11, 2012

merged branch willdurand/fix-form-type-doc (PR #3880)
Commits
-------

6f56dfc [Form] Fixed DateType default options
779d3bb [Form] Fixed documentation, and the DateType (default options)

Discussion
----------

[Form] Fixed documentation, and the DateType (default options)

---------------------------------------------------------------------------

by fabpot at 2012-04-11T16:48:04Z

That breaks the tests.

---------------------------------------------------------------------------

by willdurand at 2012-04-11T16:50:35Z

I got an error with the Form test suite before to write this patch..

---------------------------------------------------------------------------

by willdurand at 2012-04-11T16:53:30Z

Nevermind, I can see broken tests.. I'm on, sorry

---------------------------------------------------------------------------

by willdurand at 2012-04-11T16:57:52Z

@fabpot fixed.

```
OK, but incomplete or skipped tests!
Tests: 945, Assertions: 1439, Incomplete: 11.
```

@fabpot fabpot merged commit 6f56dfc into symfony:master Apr 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment