[EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber #3900

Merged
merged 1 commit into from Apr 12, 2012

Projects

None yet

2 participants

@ghost

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

This fixes a case that was not covered by the existing tests.

@fabpot fabpot added a commit that referenced this pull request Apr 12, 2012
@fabpot fabpot merged branch drak/eventsubscriber_notice (PR #3900)
Commits
-------

57dd914 [EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber with mixed priorities

Discussion
----------

[EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

This fixes a case that was not covered by the existing tests.
3bd2e01
@fabpot fabpot merged commit 57dd914 into symfony:2.0 Apr 12, 2012
@igorw igorw commented on the diff Apr 12, 2012
...sts/Component/EventDispatcher/EventDispatcherTest.php
@@ -241,6 +241,9 @@ class TestEventSubscriberWithPriorities implements EventSubscriberInterface
{
public static function getSubscribedEvents()
{
- return array('pre.foo' => array('preFoo', 10));
+ return array(
+ 'pre.foo' => array('preFoo', 10),
+ 'post.foo' => array('postFoo'),
+ );
@igorw
igorw Apr 12, 2012

CS: this should probably be unindented.

@ghost
ghost Apr 12, 2012

Done for readability.

@igorw
igorw Apr 12, 2012

Sorry, I meant:

return array(
    'pre.foo' => array('preFoo', 10),
    'post.foo' => array('postFoo'),
);
@mmucklo mmucklo pushed a commit that referenced this pull request May 23, 2013
@fabpot fabpot merged branch drak/eventsubscriber_notice (PR #3900)
Commits
-------

57dd914 [EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber with mixed priorities

Discussion
----------

[EventDispatcher] Fixed E_NOTICES with multiple eventnames per subscriber

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

This fixes a case that was not covered by the existing tests.
3e410b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment