Merged
Conversation
|
Hey! Excellent, just like I would have done it. To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
christingruber
force-pushed
the
feature/notifier-gitter-bridge
branch
2 times, most recently
from
029436a to
0fb67c8
Compare
christingruber
changed the title
OskarStark
requested changes
Jan 14, 2021
Contributor
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
Thank you for this great PR @christingruber 👍
Just some comments
src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Gitter/Tests/GitterTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Gitter/Tests/GitterTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Gitter/Tests/GitterTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Gitter/GitterTransport.php
Outdated
Show resolved
Hide resolved
christingruber
force-pushed
the
feature/notifier-gitter-bridge
branch
3 times, most recently
from
18d2f4c to
c074462
Compare
OskarStark
reviewed
Jan 15, 2021
src/Symfony/Component/Notifier/Bridge/Gitter/GitterTransportFactory.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jan 15, 2021
OskarStark
reviewed
Jan 15, 2021
OskarStark
reviewed
Jan 15, 2021
src/Symfony/Component/Notifier/Bridge/Gitter/GitterTransport.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jan 15, 2021
src/Symfony/Component/Notifier/Bridge/Gitter/Tests/GitterTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jan 15, 2021
src/Symfony/Component/Notifier/Bridge/Gitter/Tests/GitterTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jan 15, 2021
src/Symfony/Component/Notifier/Bridge/Gitter/GitterTransport.php
Outdated
Show resolved
Hide resolved
OskarStark
approved these changes
Jan 15, 2021
Contributor
|
Could you please create a docs PR and a recipe? Thanks |
christingruber
force-pushed
the
feature/notifier-gitter-bridge
branch
from
3b0dae5 to
815f845
Compare
Member
|
I am not super confident with this component. But I think it looks alright. 👍 It needs a rebase before we can merge it. |
fabpot
approved these changes
Jan 20, 2021
christingruber
force-pushed
the
feature/notifier-gitter-bridge
branch
from
815f845 to
63fba37
Compare
christingruber
force-pushed
the
feature/notifier-gitter-bridge
branch
from
63fba37 to
d033677
Compare
Contributor
Author
|
Rebase is done, thank you 👍 |
OskarStark
approved these changes
Jan 20, 2021
Contributor
|
Thanks Christin for working on this feature, this is much appreciated. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 21, 2021
…ruber) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add symfony/gitter-notifier docs See symfony/symfony#39838 Commits ------- 26e88f7 Add symfony/gitter-notifier docs
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a notifier bridge for https://gitter.im the API documentation https://developer.gitter.im/docs/rest-api.