[ErrorHandler] fix parsing return types in DebugClassLoader #40066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested review from
chalasr,
wouterj and
yceruto
as code owners
|
Hey! Two days ago, I was sitting at my usual spot at the top of Big Ben, I was thinking that we really needed this. And now, here you are with a PR. =) I think @phansys has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 10, 2021
…colas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- Re-enable triggering deprecations about return types | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Now that the three PRs linked in #40066 are merged, we can re-enable this check. Commits ------- 01ac9b1 Re-enable triggering deprecations about return types
PhilETaylor
pushed a commit
to PhilETaylor/symfony
that referenced
this pull request
Sep 6, 2023
…ssLoader (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] fix parsing return types in DebugClassLoader | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In 5.3, we might want to make `SYMFONY_PATCH_TYPE_DECLARATIONS=deprecations=1` the default, so that ppl know when they're missing some return types when they inherit some classes from vendors. This would fix https://github.com/orgs/symfony/projects/1#card-30856423 On 4.4, we have to disable this mode of reporting until these PRs are merged: - twigphp/Twig#3481 - doctrine/collections#269 - predis/predis#678 Commits ------- 58e32b3 [ErrorHandler] fix parsing return types in DebugClassLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 5.3, we might want to make
SYMFONY_PATCH_TYPE_DECLARATIONS=deprecations=1the default, so that ppl know when they're missing some return types when they inherit some classes from vendors. This would fix https://github.com/orgs/symfony/projects/1#card-30856423On 4.4, we have to disable this mode of reporting until these PRs are merged:
@returnwhen implementing base PHP types doctrine/collections#269