Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier] [FakeChat] Added the bridge #40647

Merged
merged 1 commit into from Apr 6, 2021

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Mar 31, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#15171
Recipe PR symfony/recipes#928

This PR is based on #39949 but for chat messages instead of SMS.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Apr 1, 2021
@nicolas-grekas
Copy link
Member

LICENSE and .git* files are missing

@OskarStark
Copy link
Contributor Author

LICENSE and .git* files are missing

Thanks, fixed

@OskarStark
Copy link
Contributor Author

Rebased

@OskarStark
Copy link
Contributor Author

I merge this, as its mostly a copy paste from FakeSms bridge

@OskarStark OskarStark merged commit 345eb75 into symfony:5.x Apr 6, 2021
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Apr 6, 2021
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] [FakeChat] add docs

Docs for symfony/symfony#40647

Commits
-------

018d50b [Notifier][FakeChat] add docs
{
protected $serviceProvider;

public function __construct(ServiceProviderInterface $serviceProvider)
Copy link
Member

@chalasr chalasr Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #40731, where is this locator configured? The framework integration seems broken

@OskarStark OskarStark deleted the notifier/fake-chat branch April 8, 2021 10:51
@fabpot fabpot mentioned this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants