Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Intl] Removed deprecated code #41361

Merged
merged 1 commit into from May 27, 2021
Merged

[Intl] Removed deprecated code #41361

merged 1 commit into from May 27, 2021

Conversation

malteschlueter
Copy link
Contributor

@malteschlueter malteschlueter commented May 21, 2021 •
edited by derrabus

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This remove deprecated code from Intl.

TODO

@carsonbot carsonbot added this to the 6.0 milestone May 21, 2021
@malteschlueter
Copy link
Contributor Author

malteschlueter commented May 21, 2021 •
edited

What should I do within the Resources directory? I'm not sure. Do I have to delete there something?

@malteschlueter malteschlueter mentioned this pull request May 21, 2021
Closed
@carsonbot
Copy link

Hey!

I think @tigitz has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

nicolas-grekas
nicolas-grekas reviewed May 23, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase needed

src/Symfony/Component/Intl/CHANGELOG.md Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member

Thank you @malteschlueter.

@nicolas-grekas nicolas-grekas merged commit 5f101e0 into symfony:6.0 May 27, 2021
@fabpot fabpot mentioned this pull request Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Intl Status: Needs Review
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malteschlueter @carsonbot @nicolas-grekas @derrabus