[FrameworkBundle] Deprecate AbstractController::get() and has() #42442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 9, 2021
fabpot
force-pushed
the
abstract-controller-get-has-deprecation
branch
from
762cfc1
to
eb14ee5
Compare
fabpot
force-pushed
the
abstract-controller-get-has-deprecation
branch
from
eb14ee5
to
f4ee152
Compare
zairigimad
approved these changes
Aug 9, 2021
OskarStark
approved these changes
Aug 9, 2021
fabpot
force-pushed
the
abstract-controller-get-has-deprecation
branch
from
f4ee152
to
66a81ea
Compare
derrabus
approved these changes
Aug 9, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controllers extending
AbstractControllerhave access to the services registered for the shortcuts defined inAbstractControllerviaget()andhas(). These methods can make developers think that they have access to the whole container, which is not true. Moreover, the limited set of services are precisely the ones needed for the shortcuts, so probably not the ones people would need anyway.I propose to deprecate these methods and advocate using method/constructor injection instead.
If people want to still use the container, they can access it via the
$this->containerproperty (useful if they extendgetSubscribedServices()for instance).