Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Count remember me cookie parts before accessing the second #47368

Merged
merged 1 commit into from Aug 23, 2022
Merged

[Security] Count remember me cookie parts before accessing the second #47368

merged 1 commit into from Aug 23, 2022

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Aug 23, 2022 •
edited

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47362
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 5.4 milestone Aug 23, 2022
xabbuh
xabbuh approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatTheCat
Copy link
Contributor Author

I tried many formats but GitHub won’t link my PRs to the corresponding issue; I don’t know what’s going on :/

@xabbuh xabbuh linked an issue Aug 23, 2022 that may be closed by this pull request
[Security][RememberMe] Undefined array key 1 #47362
Closed
@fabpot
Copy link
Member

fabpot commented Aug 23, 2022

Thank you @MatTheCat.

@fabpot fabpot merged commit 6dadb96 into symfony:5.4 Aug 23, 2022
This was referenced Aug 26, 2022
Merged
Merged
Merged
@MatTheCat MatTheCat deleted the ticket_47362 branch August 26, 2022 14:57
@fabpot fabpot mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Security][RememberMe] Undefined array key 1
4 participants
@MatTheCat @fabpot @xabbuh @carsonbot