[Serializer] Fix denormalization of object with typed constructor arg (not castable) and with COLLECT_DENORMALIZATION_ERRORS #50024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a test for constructor instantiation but it worked "by chance".
The test is
testCollectDenormalizationErrorsWithConstructor
.It worked because
$reflectionClass->newInstanceArgs($params)
works ifone give a
string
value that should fit in abool
type. PHP castsautomatically the value for us. (see: https://3v4l.org/GYr0T)
Now we ensure to not throw an exception if the instantiation cannot be
done. The mismatch is already collected few lines above, so there
nothing to do more