New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update src/Symfony/Component/Form/Extension/Core/Type/FileType.php #5028
Conversation
Thank you for the PR! Could you please add a test case? |
And what to check? I added one static option :) |
Whatever was the reason for adding the option ;) The test should fail when the option is not added and succeed when the option is there. Probably it is sufficient to create a new field of type "file" in the test which comes prefilled with a
|
sorry, it's bug in VichUploaderBundle |
or not :) |
@bschussek done! it was really a bug with FileType |
@stof who can merge it? I want close this bug dustin10/VichUploaderBundle#27 :) |
@fabpot do you have a minute :)? it's simple PR but many people wait for it |
Hello, Since this update, I've got a 500 error instead of validation failure when I try to post a form without a required file.
|
I have same error as @fvilpoix |
I have the same error on my side. This change means that we must necessarily provide Symfony File objects on forms input and output ? I fail to see how this can work as in this case, nothing is passed to the File constructor. |
Hmm. @bschussek, "Houston, we have a problem" |
+1 same error ! |
@fabpot can you revert changes? and reopen this issue. |
I am getting this same error. |
I did find this 'fix': |
Same error. |
Yes, I have the same error, when i edit, and when the field file is empty :( |
The fix posted by dchaffin works for me. It's a little worrying that a security update (2.1.4) ended up breaking functionality. |
Same error and the fix posted by dchaffin doesn't works for me :/ |
Same error to minoz and the fix posted by dchaffin doesn't works for me to |
Fixed in #6319 |
fixed dustin10/VichUploaderBundle#27