Update src/Symfony/Component/Form/Extension/Core/Type/FileType.php

[stfalcon]

fixed dustin10/VichUploaderBundle#27

[webmozart]

Thank you for the PR! Could you please add a test case?

[stfalcon]

Could you please add a test case?

And what to check? I added one static option :)

[webmozart]

Whatever was the reason for adding the option ;) The test should fail when the option is not added and succeed when the option is there.

Probably it is sufficient to create a new field of type "file" in the test which comes prefilled with a File object.

$file = $this->getMock('Symfony\Component\HttpFoundation\File\File');
$this->factory->create('file', $file)

[stfalcon]

sorry, it's bug in VichUploaderBundle

[stfalcon]

or not :)

[stfalcon]

@bschussek done! it was really a bug with FileType

[stfalcon]

@stof who can merge it? I want close this bug dustin10/VichUploaderBundle#27 :)

[stof]

@stfalcon the rule is that only @fabpot merges PRs on symfony.

[stfalcon]

@fabpot do you have a minute :)? it's simple PR but many people wait for it

[fvilpoix]

Hello,

Since this update, I've got a 500 error instead of validation failure when I try to post a form without a required file.

Warning: Missing argument 1 for Symfony\Component\HttpFoundation\File\File::__construct(), called in […]/vendor/symfony/symfony/src/Symfony/Component/Form/Extension/Core/Type/FormType.php on line 172 and defined in […]/vendor/symfony/symfony/src/Symfony/Component/HttpFoundation/File/File.php line 38

[piotrantosik]

I have same error as @fvilpoix

[choomz]

I have the same error on my side. This change means that we must necessarily provide Symfony File objects on forms input and output ?

I fail to see how this can work as in this case, nothing is passed to the File constructor.

[stfalcon]

Hmm. @bschussek, "Houston, we have a problem"

[Sybio]

+1 same error !

[stfalcon]

@fabpot can you revert changes? and reopen this issue.

[dchaffin]

I am getting this same error.

[dchaffin]

I did find this 'fix':

#6134

[frodosghost]

Same error.

[minart]

Yes, I have the same error, when i edit, and when the field file is empty :(

[gzankevich]

The fix posted by dchaffin works for me. It's a little worrying that a security update (2.1.4) ended up breaking functionality.

[ghost]

Same error and the fix posted by dchaffin doesn't works for me :/

[alainivars]

Same error to minoz and the fix posted by dchaffin doesn't works for me to

[webmozart]

Fixed in #6319